search

DevExpress / testcafe-browser-provider-saucelabs

This is the Sauce Labs browser provider plugin for TestCafe.
https://devexpress.github.io/testcafe/
MIT License
32 stars 41 forks source link

Allow consumers of this package to pass in overrides for Sauce Connect Proxy #74

Closed sdotson closed 3 years ago

sdotson commented 3 years ago

There are many scenarios where these options, especially directDomains or noSslBumpDomains, would be really useful for the consumer of this package to specify. At the moment, these are hard-coded: https://github.com/DevExpress/testcafe-browser-provider-saucelabs/blob/master/src/index.js#L187-L189 , which makes it impossible for me to test web socket functionality due to the inability to specify noSslBumpDomains.

My proposal is that we use a similar mechanism that this package already does for SAUCE_CAPABILITIES_OVERRIDES_PATH, perhaps called SAUCE_CONNECT_OVERRIDES_PATH, where consumers can specify their overrides.

Happy to open a pr for the approach outlined above or an alternative that the maintainers think is better.

sdotson commented 3 years ago

Went ahead and opened a pr because "why not?".

viktoria2506 commented 3 years ago

Thank you for the contribution to Testcafe.