search

DevExpress / testcafe-browser-provider-saucelabs

This is the Sauce Labs browser provider plugin for TestCafe.
https://devexpress.github.io/testcafe/
MIT License
32 stars 41 forks source link

Add SAUCE_CONNECT_OVERRIDES_PATH #75

Closed sdotson closed 3 years ago

sdotson commented 3 years ago

See https://github.com/DevExpress/testcafe-browser-provider-saucelabs/issues/74 for more details.

miherlosev commented 3 years ago

Hi @sdotson

Thank you for your contribution to the testcafe-browser-provider-saucelabs module. We will review it.

wentwrong commented 3 years ago

We'll be happy to accept this pull request, but we need to see your tests first. Would you please add a unit test similar to this one, which checks whether the passed file with the SauceLabs capabilities was parsed successfully?

sdotson commented 3 years ago

@wentwrong good idea! I went ahead and added unit tests. Also did a light refactor to abstract that out to a new method to make that easier to test.

sdotson commented 3 years ago

Updated! Thanks for the reviews everybody.