DevExpress / testcafe-react-selectors

TestCafe selector extensions for React apps.
https://testcafe.io
MIT License
203 stars 43 forks source link

waitForReact fails when called from node callback #148

Closed theoinglis closed 5 years ago

theoinglis commented 5 years ago

I have created a PR for this issue: https://github.com/DevExpress/testcafe-react-selectors/pull/147

it is simply to allow the testController to be passed in when the testController can't be picked up automatically and is for this edge case: https://devexpress.github.io/testcafe/documentation/test-api/selecting-page-elements/selectors/edge-cases-and-limitations.html#calling-selectors-from-nodejs-callbacks

There are further details in the PR.

Please let me know if you need any more information.

Thanks!

AlexKamaev commented 5 years ago

Thank you for contributing to TestCafe. We will review your PR and give you feedback.

kirovboris commented 5 years ago

I've published testcafe-react-selectors@3.2.0

theoinglis commented 5 years ago

Thanks very much!