search

DevExpress / testcafe-react-selectors

TestCafe selector extensions for React apps.
https://testcafe.io
MIT License
205 stars 43 forks source link

feat: support finding dom node when in sibling of selected component's child #188

Closed AudunWA closed 2 years ago

AudunWA commented 2 years ago

I've documented the missing case with a test that fails before applying my changes. This change allows us to find the DOM nodes of components even if the first child doesn't render anything.

I'm open to style or implementation changes. 🙂

kirovboris commented 2 years ago

Thank you for your contribution! Could you please improve the test case? It passes even without the suggested changes.

AudunWA commented 2 years ago

Thanks for pointing out the bad test, it should be failing without the changes now @kirovboris.

kirovboris commented 2 years ago

Tusen takk @AudunWA, I'll release a new version soon.

kirovboris commented 2 years ago

published testcafe-react-selectors@5.0.2