DevExpress / testcafe-react-selectors

TestCafe selector extensions for React apps.
https://testcafe.io
MIT License
205 stars 43 forks source link

fix: added another check for component props #197

Closed denisputnov closed 1 year ago

denisputnov commented 1 year ago

Closes #196

Please check linked issue to get more information about the problem


Required to avoid a TypeError on a subsequent lines for React v18+:

TypeError: Cannot read properties of null (reading 'hasOwnProperty')
denisputnov commented 1 year ago

AppVeyor build logs looks strange to me

Looks like node_modules linting too

denisputnov commented 1 year ago

Hi, @kirovboris!

This is a friendly reminder about the Pull Request and previously opened issue #196. Your review is required! Please let me know when you check my proposal.

Thank you!

kirovboris commented 1 year ago

@denisputnov Could you share any details about how you create the target and its parent components? It doesn't contain props, so it has to be some unhandled component type.

The issues we met before were related to things like portal components, async loading suspense components, tag components, components with empty states, hydrated components, nested root components, etc. It may help find a good test case.

Also, could you check this issue on 18.0 React or earlier versions? It might help us understand if any new react functionality produces this behavior.

denisputnov commented 1 year ago

Hi @kirovboris,

We are using dynamic imports with build in import function and that's all specific functionality.

The issue reproduces on React 18.x.x, it does not reproduce on lesser versions of React.

I can assume, that the issue is affected by some concurrent rendering features in the React.

kirovboris commented 1 year ago

Published testcafe-react-selectors@5.0.3

denisputnov commented 1 year ago

All participated, thank you very much for your help!