search

DevExpress / testcafe-reporter-xunit

This is the xUnit reporter plugin for TestCafe.
https://testcafe.io
MIT License
10 stars 30 forks source link

Add a failing test for producing valid XML #39

Closed malloryavvir closed 1 year ago

malloryavvir commented 1 year ago

I replaced the illegal character in the expected XML outputs for the other tests with the replacement character (U+FFFD) as that's probably the correct behavior.

This allows reproducing the bug reported here: #33

Note: you will need xmlstarlet installed for this test (it's available in APT and homebrew, and probably anywhere else). I tried to use an XML validator that was a node package, but the one I tried said that the document was valid despite containing invalid characters, so I gave up on that approach.

AlexKamaev commented 1 year ago

Thank you for writing a test to demonstrate the incorrect behavior. Would you like to continue working on this PR to fix the issue? If so, please see the following code: https://github.com/DevExpress/testcafe-reporter-xunit/blob/108b1b7a9e526c72c8303d2af7722f126c921369/src/index.js#L37

malloryavvir commented 1 year ago

I updated the PR to replace illegal characters with the replacement character. I also removed the test that depended on xmlstarlet being installed.

AlexKamaev commented 1 year ago

Currently, I do not have any additional questions about this PR. I'll check it one more time and merge it after v3.3.0 is released