search

DevInsideYou / SpotifyWeb

Displays the current track in the status bar of Sublime Text.
MIT License
12 stars 3 forks source link

[Enhancement] Showing artist name with the song #2

Closed berenceylan closed 5 years ago

berenceylan commented 5 years ago

I conditionally added artist name next to the song's name

berenceylan commented 5 years ago

Error fix will be made

agilesteel commented 5 years ago

Hey man, no worries, thx for contributing. Listen I wish I could merge it in, but there is an issue (not related to your error). When I wrote the plugin back in the day I made a mistake of caching the auth token in a file inside of the plugin folder. This means that every time I release a new version packagecontrol will overwrite the entire plugin and thus delete the token and people's browser will pop up to reauthenticate. Once I noticed this annoyance I told myself that "the next" version I release will at the very least move the location of the cache file to the home folder for example. This way it will be the last time this annoys people. But I never worked on the plugin ever since and I don't have much time these days. So I'm sorry to tell you this, but unless you spend a bit of time and do this for me (change the destination of the cache, IIRC fix the tests and test it manually on at least windows and some version of linux) I won't be able to accept your pull request. It shouldn't take too long, but I really don't have the time now.

berenceylan commented 5 years ago

Oh man i see. Thanks for being informative! Let's see what we can do. I'll let you know.