search

DevJaGz / app-fast-marquee

Marquee site and library made in Angular
2 stars 1 forks source link

CPU consumption #2

Closed fromage9747 closed 2 months ago

fromage9747 commented 2 months ago

Recently discovered that each instance of ngx-fast-marquee can consume up to 20% of the CPU in the browser.

I have a Babylonjs scene and two marquee instances overlayed. This 40% cpu usage causes the FPS of my Babylonjs scene to drop to near 20FPS.

Of course, I can just not use your repo but thought I would let you know.

It's a great repo and works the best from various implementations I have tried, but I wonder if there is a way to limit the amount of function calls so that Angular is not chewing through the CPU cycles unnecessarily.

DevJaGz commented 2 months ago

Hi @fromage9747, thanks for your message! The marquee updates under the following conditions:

I suggest validating whether your code is triggering these conditions. If the issue persists, feel free to provide more details, and I'll be happy to assist further.

fromage9747 commented 2 months ago

@DevJaGz

Hey man, thanks for the reply. I went and console logged all the methods in the ts file and pretty much they are just continuously running.

I'm not doing anything weird with your repo, just installed and added it.

I spent the afternoon creating a pure CSS implementation which has suited my needs. Pretty much exactly the same as what yours produces with almost nothing on the CPU.

Cheers!

DevJaGz commented 2 months ago

Hi @fromage9747, thanks for the update! Glad to hear you found a solution that works well for your needs. A pure CSS implementation is a great approach, especially for reducing CPU usage.

If you ever want to revisit using the library or need any further help, feel free to reach out. Cheers, and best of luck with your project!