search

DevLeoko / AdvancedBan

AdvancedBan is a Spigot plugin to manage punishments on single servers and server networks
GNU General Public License v3.0
158 stars 130 forks source link

Permission system setup #584

Open omnikeycard opened 2 years ago

DevLeoko commented 2 years ago

Even though I always prefer to implement standardized specifications, I think adding permission nodes to the plugin.yml prevents our command handlers to be called when the user does not have permission. Thus our custom "no-permission" message is not displayed and more complex permission requirements can not be handled. I have also not been able to find a specification for default: false. Please correct me if I am wrong.

Hopefuls commented 2 years ago

I have also not been able to find a specification for default: false. Please correct me if I am wrong.

According to spigotmc:

default Sets the default value of the permission. If nodes does not exist, permission defaults to op. Allowed defaults are: true, false, op, not op

true default will always grant the player the permission. false default will not grant the player the permission. op default will be true if the player is op. not op is the opposite behavior of op.

So as far as I am seeing, setting it to false would disable that by default, requiring the user to have one of advancedbans permissions?

EDIT: Or it would entirely make the advancedban command unusable.