search

DevLeoko / AdvancedBan

AdvancedBan is a Spigot plugin to manage punishments on single servers and server networks
GNU General Public License v3.0
158 stars 130 forks source link

AdvancedBan can't prevent chat messages even if player is muted when ChatControlPRO formatting.yml is enabled #589

Open TheJoshue opened 1 year ago

TheJoshue commented 1 year ago

What version of AdvancedBan (/AdvancedBan) are you using? image

What kind of server do you have (Bungeecord/single server)? Single server

What server version (/version) are you using? image

Please provide the EXACT steps required to reproduce the problem...

  1. Install ChatControlPRO plugin
  2. Install AdvancedBan plugin
  3. Start server to load configs
  4. Go into plugins/ChatControl/formatting.yml file
  5. Set Enabled to true to enable formatting of messages
  6. Go onto server and reload CHC plugin (/chc reload)
  7. Mute some player using AdvancedBan plugin (/mute Player1 some reason)
  8. When that player try to send chat message he will get AdvancedBan deny message but his message will however be sent to the chat

Any error/log post it through pastebin.com and link it here. (Also include /plugins/AdvancedBan/logs/latest.log) No

Add any additional information below. No

Hopefuls commented 1 year ago

Due to the nature of how this plugin is made, aka it not being open source, I cannot give a definite answer to that.

What I'm thinking is happening here is that ChatControlPRO does not respect the chat event status that AdvancedBan has set. Please reach out to their support instead.

Thank you.

TheJoshue commented 1 year ago

Due to the nature of how this plugin is made, aka it not being open source, I cannot give a definite answer to that.

What I'm thinking is happening here is that ChatControlPRO does not respect the chat event status that AdvancedBan has set. Please reach out to their support instead.

Thank you.

This is what i got as an answer from LiteBans developer - I asked him to share a part of code how he handles on player chat event if player is muted; can you please try forking and doing this what he said? because litebans successfully prevents ChatControlPRO's formatted message from being sent if player is muted; AdvancedBan not image

Hopefuls commented 1 year ago

This still does not bring this issue further, as neither I or the actual Developers of AdvancedBan can look into how ChatControl acts on event priorities. There had been issues like this before, but this is mostly due to disagreement between plugins and their event priorities. I have already started implementing features to allow server administrators to configure priorities themselves to act on other plugins accordingly.

Other than that, you're likely not going to be able to use AdvancedBan with ChatControlPro.

TheJoshue commented 1 year ago

I fixed it, was simple fix image