Add CloudnetV4 support and maven depedency fix

DevLeoko / AdvancedBan

AdvancedBan is a Spigot plugin to manage punishments on single servers and server networks

GNU General Public License v3.0

156 stars 128 forks source link

Add CloudnetV4 support and maven depedency fix #600

Open Phyrone opened 1 year ago

Phyrone commented 1 year ago

kick player using cloudnet v4 instant of bungeecord (like version 3 and 2 support)
- fix player not kicked when using cloudnet v4
updated maven dependencies necessary to compile

CloudnetV4 is at the moment of this pull request still in release candidate state. It's still possible that the API changes, however I consider it as very unlikely.

DevLeoko commented 1 year ago

Looks good - has this been tested with the latest CloudNet V4 build?

Phyrone commented 1 year ago

I installed it on my network(which is v4 - rc5) for a few hours now, and it works fine so far.

Phyrone commented 1 year ago

However cloudnet v4 uses adventure text, and I was not sure first, how to convert. I used legacy next convert for (like bungeecord TextComponent.fromLeagytext) now. I think that's the correct one.

DevLeoko commented 1 year ago

Seems like something with the Cloudnet V4 dependency is wrong (see automated test)

Phyrone commented 1 year ago

Looks like cloudnet 4 requires at least java 17 meanwhile advancedbans still compiles on java 1.8. i dont know how to solve this without upgrading advancedbans to java 17