search

DevLeoko / AdvancedBan

AdvancedBan is a Spigot plugin to manage punishments on single servers and server networks
GNU General Public License v3.0
162 stars 131 forks source link

Made notifications for a silent punishment #624

Closed tWizT3ddreaMr closed 1 year ago

tWizT3ddreaMr commented 1 year ago

The silent notification perm is the same as notify but silentnotify, seems like it should be that, but I was not sure how you would want to structure the perm

so permission for silent mute is ab.silentnotify.mute

This is for feature request #557 Resubmitted for the developement branch since it wasn't letting me change base

Hopefuls commented 1 year ago

Is it possible to have this be unified with the current permissions?

Such as: ab.silentnotify.tempban -> ab.notify.tempban.silent

tWizT3ddreaMr commented 1 year ago

It sure is, however I did it this way so if one were to give ab.notifify.* that wouldn't include these for ease of use and to avoid any unseen issues. However I am not attached to the permission being separate as most people getting one will get the other on my server.

DevLeoko commented 1 year ago

I actually think that ab.silentnotify.* aligns pretty well with our current permission layout, given that we also have ab.undoNotify.*. Also, I think it is good that ab.notify.* does not include the silent notify permissions.

So if you don't have any objections @Hopefuls I'd approve and merge

Hopefuls commented 1 year ago

Yup looks good to me