DevLeoko / AdvancedBan

AdvancedBan is a Spigot plugin to manage punishments on single servers and server networks
GNU General Public License v3.0
156 stars 128 forks source link

Added velocity support #641

Open KikyoC opened 2 months ago

KikyoC commented 2 months ago

Hello, I added velocity support and I tested it and it looks working. I checked that the /unban bug (because of not cached) is fixed.

Hopefuls commented 1 month ago

are the changes based off of the development branch?

KikyoC commented 1 month ago

Nope I don't think, you can see here that I'm up to date with leoko dev branch here: https://github.com/KikyoC/AdvancedBan/tree/master

Bensonheimer992 commented 3 weeks ago

Hey every time i ban someone with the Velocity Version of AdvancedBan i have to restart the proxy to unban them if i don't restart the proxy i get the message that this player is not banned

Hopefuls commented 3 weeks ago

Hey every time i ban someone with the Velocity Version of AdvancedBan i have to restart the proxy to unban them if i don't restart the proxy i get the message that this player is not banned

is this related to this pull request? if no then that is known.

KikyoC commented 3 weeks ago

Hey every time i ban someone with the Velocity Version of AdvancedBan i have to restart the proxy to unban them if i don't restart the proxy i get the message that this player is not banned

Hello, check this one, I'm waiting they response to open a second pr (because I did something stupid): https://github.com/Swordfun-Server/AdvancedBan

Bensonheimer992 commented 3 weeks ago

Hey every time i ban someone with the Velocity Version of AdvancedBan i have to restart the proxy to unban them if i don't restart the proxy i get the message that this player is not banned

Hello, check this one, I'm waiting they response to open a second pr (because I did something stupid): https://github.com/Swordfun-Server/AdvancedBan

this version does not work either it still says after banning this player is not banned

KikyoC commented 3 weeks ago

Hey every time i ban someone with the Velocity Version of AdvancedBan i have to restart the proxy to unban them if i don't restart the proxy i get the message that this player is not banned

Hello, check this one, I'm waiting they response to open a second pr (because I did something stupid): https://github.com/Swordfun-Server/AdvancedBan

this version does not work either it still says after banning this player is not banned

I don't have this issue. i'm checking it

KikyoC commented 3 weeks ago

Hey every time i ban someone with the Velocity Version of AdvancedBan i have to restart the proxy to unban them if i don't restart the proxy i get the message that this player is not banned

Hello, check this one, I'm waiting they response to open a second pr (because I did something stupid): https://github.com/Swordfun-Server/AdvancedBan

this version does not work either it still says after banning this player is not banned

I missed something. Should now work (with new release)

Bensonheimer992 commented 3 weeks ago

can i still use the normal advancedban api or do i have to do something special for it to work with the velocity version ?

Bensonheimer992 commented 3 weeks ago

can i still use the normal advancedban api or do i have to do something special for it to work with the velocity version ?

because im trying to use the PunishEvent and nothing happens (i checked that the event is registered)

Bensonheimer992 commented 2 weeks ago

Hey every time i ban someone with the Velocity Version of AdvancedBan i have to restart the proxy to unban them if i don't restart the proxy i get the message that this player is not banned

Hello, check this one, I'm waiting they response to open a second pr (because I did something stupid): https://github.com/Swordfun-Server/AdvancedBan

this version does not work either it still says after banning this player is not banned

I missed something. Should now work (with new release)

?

KikyoC commented 2 weeks ago

Hello, I havent edited anything from the api.

Bensonheimer992 commented 2 weeks ago

but the event does not get triggered

Bensonheimer992 commented 2 weeks ago

Hello, I havent edited anything from the api.

and maybe change the server type from BungeeCord to Velocity

DevLeoko commented 1 week ago

Thanks for your effort to support velocity @KikyoC Are the changes from this PR tested and stable? Because you mentioned newer changes and a second PR above.