search

DevLeonardoCommunity / github-stats

Aggregating and displaying YOUR GitHub Stats in meaningful metrics (we learn web development in the meantime)
https://public-github-stats.vercel.app
MIT License
71 stars 37 forks source link

Wrong icon in open Pull Requests #110

Closed Balastrong closed 8 months ago

Balastrong commented 9 months ago

Describe your issue

Here on line 83 we show the GoIssueOpened icon which renders the open issue icon. I think there should be a dedicated icon for open pull requests.

https://github.com/DevLeonardoCommunity/github-stats/blob/d71c03f97f12354e7c82b5ae5ca7c50c0cb28056/src/components/RepositoryContributionsCard.tsx#L78-L84

Steps to reproduce

  1. Login
  2. Go to the stats page
  3. Have an open PR in your cards

What was the expected result?

No response

Put here any screenshots or videos (optional)

image

Would you like to work on this issue?

None

priyankarpal commented 9 months ago

It should have the same icon as the merged PR, but the color should be green. What do you think?

Balastrong commented 9 months ago

There should be an Icon for open PRs too if I'm not mistaken

K1ethoang commented 8 months ago

You want to like that?

image

K1ethoang commented 8 months ago

114

Balastrong commented 8 months ago

Done in #114