search

DevLeonardoCommunity / github-stats

Aggregating and displaying YOUR GitHub Stats in meaningful metrics (we learn web development in the meantime)
https://public-github-stats.vercel.app
MIT License
71 stars 36 forks source link

feat: add text for no-results #33

Closed theanantchoubey closed 1 year ago

theanantchoubey commented 1 year ago

This PR resolves the #23 Issue. In case of non-availability of the data in a specific year, it shows "No Contribution" as text.

vercel[bot] commented 1 year ago

Someone is attempting to deploy a commit to a Personal Account owned by @Balastrong on Vercel.

@Balastrong first needs to authorize it.

Balastrong commented 1 year ago

Thanks for the PR!

We already had a nested ternary to display the three different modes, I'd rather not add an extra ternary on top of this, we should refactor things a little bit.

I would be ok with either an IIFE for the three formats or extracting something into separate functions/components.

(also don't forget to format your code with prettier)

theanantchoubey commented 1 year ago

Ok Thanks for the corrections! I will implement it and get back then.

theanantchoubey commented 1 year ago

Please have a review, I have made the required changes.