DevLeonardoCommunity / github-stats

Aggregating and displaying YOUR GitHub Stats in meaningful metrics (we learn web development in the meantime)
https://public-github-stats.vercel.app
MIT License
71 stars 36 forks source link

Bug: Background color is limited to the screen size only #42

Closed theanantchoubey closed 1 year ago

theanantchoubey commented 1 year ago

Bug description Background height is fixed to 100% only, which leads to the background color filling until the screen's size only.

Reproduction steps

  1. Go to the home page
  2. Scroll down
  3. You will see a partition of 2 colors, a black and a grey

[Alternatively]

  1. Go to your Stats Page
  2. Check your stats in a format where the size of the screen exceeds
  3. Scroll down and you will notice the issue

Expected behavior The background color should be there until the bottom of the page.

Screenshots

temp

Additional context

Balastrong commented 1 year ago

Thanks for the report!

I think this has the same root cause as #41, there's something wrong with the background and the overflowing behaviour.

If you agree it's the same I'll mark this as duplicate and we can discuss it there, if you think this is a separate one I'll leave this open :)

theanantchoubey commented 1 year ago

Thanks for Checking out! In the case of my issue, the root cause is the height set to 100%. But in the #41 case, the data is overflowing, what are your thoughts on its cause? Note: I tried fixing my issue but it is not fixing #41

Balastrong commented 1 year ago

Ok then, we can keep them separate :)