fix: export button placement in text mode

[jakubfronczyk]

Change button placement outside <pre> tag.

I spotted types problem. I used custom types from types/github.ts file.

[vercel[bot]]

Someone is attempting to deploy a commit to a Personal Account owned by @Balastrong on Vercel.

@Balastrong first needs to authorize it.

[Balastrong]

Thank you for the PR!

The fix looks good, but I don't see why we need to add those types explicitly. What errors did you get?

[jakubfronczyk]

I get "Binding element 'repository' implicitly has an any type. Error that occurs when TypeScript can't determine the type of a variable or parameter automatically. To address this issue, I added explicit type annotations using our custom types. By specifying the expected types for repository and contributions using the custom PullRequestContributionsByRepository type, we could enhance type-safety and catch potential type-related issues at compile time.

[Balastrong]

Thanks for the details! I'm asking because on visual studio code I already see the types there properly. Are you using some strict extension or a different editor?

repositories is already typed and it's an array, I'm assuming calling .map on it should infer the types of each element with no effort.

What happens if you explicitly type it on line 18 instead? Would that still need the extra typings in the .map?

  const {
    repositories,
    isLoading,
  }: {
    repositories: PullRequestContributionsByRepository[];
    isLoading: boolean;
  } = useGitHubPullRequests(year, login as string);

[jakubfronczyk]

I'm using the VSCode and if i'm not wrong it's not specifically related to an extension, when you have the TypeScript language service enabled the editor itself will highlight these errors.

Your apporach also works and we don't need extra typing in .map I'm thinking it is even better becasue also ensures type safety across your codebase wherever these variables are used.

[Balastrong]

That's great, thank you!

Then if that's also ok for you to move that type there I'll merge the PR after your commit :)

[jakubfronczyk]

I pushed changes.

Thank you :) It seems really fun project, I hope I could help more.

[Balastrong]

@all-contributors please add @jakubfronczyk for code

[allcontributors[bot]]

@Balastrong

I've put up a pull request to add @jakubfronczyk! :tada: