DevLeonardoCommunity / github-stats

Aggregating and displaying YOUR GitHub Stats in meaningful metrics (we learn web development in the meantime)
https://public-github-stats.vercel.app
MIT License
71 stars 36 forks source link

feat: dark mode toggle #66

Closed black-arm closed 11 months ago

Balastrong commented 12 months ago

Thank you for the PR!

The theme changes seems to be working fine, but the light theme has quite some issues, in particular in the navbar as mentioned in #48

@Agrimaagrawal maybe you can work with @black-arm to take care about that? I'd probably like to see the light theme fixed first, so we can safely merge this PR to show the toggle to everyone.

What do you think?

black-arm commented 11 months ago

Hi, I found problems with system preferences:

:root {
  --foreground-rgb: 0, 0, 0;
  --background-start-rgb: 214, 219, 220;
  --background-end-rgb: 255, 255, 255;
}

@media (prefers-color-scheme: dark) {
  :root {
    --foreground-rgb: 255, 255, 255;
    --background-start-rgb: 0, 0, 0;
    --background-end-rgb: 0, 0, 0;
  }
}

body {
  color: rgb(var(--foreground-rgb));
  background: linear-gradient(
      to bottom,
      transparent,
      rgb(var(--background-end-rgb))
    )
    rgb(var(--background-start-rgb));
}

With this properties if I choose light theme at the evening I have the components light but the body black. The solution is to add this properties in tailwind and to add the item system in the dropdown.

Balastrong commented 11 months ago

LGTM, thank you for all the fixes! :)