search

DevLeonardoCommunity / github-stats

Aggregating and displaying YOUR GitHub Stats in meaningful metrics (we learn web development in the meantime)
https://public-github-stats.vercel.app
MIT License
71 stars 36 forks source link

Broken layout if contribution title is too long #93

Closed theflucs closed 8 months ago

theflucs commented 8 months ago

Describe your issue

If PR title is too long the icon is cut

Steps to reproduce

  1. Go to page /stats
  2. You're able to see the issue if a contribution title is quite long

What was the expected result?

I expect the layout to stay consistent regardless of the content.

Put here any screenshots or videos (optional)

Screenshot 2024-01-18 at 14 05 15

Would you like to work on this issue?

Yes

theflucs commented 8 months ago

I see 2 options:

  1. show the 3 dots to indicate that the string continues
  2. go to new line without breaking the layout

I would go for the first option, but @Balastrong tell me what you prefer

Balastrong commented 8 months ago

I'd say first option but if you hover with the mouse a tooltip shows the full name. What do you think?

theflucs commented 8 months ago

I couldn't see any tooltip hovering the pr title. Using the Daisy UI tooltip was breaking the layout, so I just added an a title attribute for accessibility and clarity.

Balastrong commented 8 months ago

That makes sense, thanks you!

I created a new issue #95 if someone wants to pick it up to specifically work on the tooltip :)