search

DevLeonardoCommunity / github-stats

Aggregating and displaying YOUR GitHub Stats in meaningful metrics (we learn web development in the meantime)
https://public-github-stats.vercel.app
MIT License
71 stars 37 forks source link

Add tooltip to long PR titles #95

Open Balastrong opened 9 months ago

Balastrong commented 9 months ago

Describe the feature

With #94 we fixed an issue on long titles, would be an additional feature to also have a tooltip when hovering on long/cut titles

It should be implemented because

No response

Additional context

No response

Would you like to work on this issue?

None

CBID2 commented 9 months ago

I’ll work on this! :)

Balastrong commented 9 months ago

Hey @CBID2, I see something similar is being worked on #101 (no worries, the PR was opened after your comment), would you mind doing the review of that PR?

CBID2 commented 9 months ago

Hey @CBID2, I see something similar is being worked on #101 (no worries, the PR was opened after your comment), would you mind doing the review of that PR?

Sure

Balastrong commented 9 months ago

Thank you :)

CBID2 commented 9 months ago

Thank you :)

Can you approve the deployment in PR #101 @Balastrong? :) It was be easier for me to test this in the context of a website.

Balastrong commented 9 months ago

You're right, approved!

However let's see if it works... we had issues with login on preview builds (see #22).

The issue was on Vercel, now I switched to Nelify because Vercel didn't allow a free plan for organizations but the issue is probably still there.

If it doesn't work, you can checkout the PR branch locally :)

CBID2 commented 9 months ago

You're right, approved!

However let's see if it works... we had issues with login on preview builds (see #22).

The issue was on Vercel, now I switched to Nelify because Vercel didn't allow a free plan for organizations but the issue is probably still there.

If it doesn't work, you can checkout the PR branch locally :)

Ok

theflucs commented 9 months ago

I made it working using react-tooltip instead of daisy-ui's. It would be better to use the same tooltip library to maintain consistency in the codebase. @Balastrong what do you think?

Balastrong commented 9 months ago

That's ok for now :)