search

DevLifts / devlifts-api

MIT License
6 stars 4 forks source link

Added eslint config #9

Open ghost opened 6 years ago

ghost commented 6 years ago

This is a hybrid config built on Wes Bos' eslint configuration. I have been using it on React, Express, and GraphQL projects for the last 6 months or so.

ghost commented 6 years ago

@mtliendo Hi Michael

What engine specs are you looking for? I went with "node": ">=0.10.3 <0.12"

All the other comment recommendations should be taken care of.

Share your thoughts.

mtliendo commented 6 years ago

I don't think we should support unmaintained versions of node. It's safe to use node >=8. I'd prefer to just support 10, but technically both are the current release.

ghost commented 6 years ago

@mtliendo I had a chance to swap out the node version. Happy to help. -Cheers

ghost commented 6 years ago

Quick question. Are you considering GraphQL for any part of the API?