search

DevLifts / devlifts-static

Static frontend for DevLifts launch
3 stars 6 forks source link

Next button is behind the Intercom button on mobile #3

Closed jchiatt closed 5 years ago

jchiatt commented 6 years ago

https://jchiatt.d.pr/uCCLaL

davidblackwelder commented 6 years ago

First time I'm brave enough to contribute to open source, I looked for rules on contributing but didn't see anything. Am I able to tackle this?

jchiatt commented 6 years ago

@davidblackwelder we don’t have any rules yet - it’s the Wild West! Go for it!

Sent with GitHawk

KempfCreative commented 5 years ago

@jchiatt I don't see any progress on this, so I would love to take it on.

As far as I can tell there are 3 approaches, increasing in complexity, of which I have taken the least complex and easiest:

  1. Add a bottom margin on the snipcart next button with enough specificity to get around the lack of access to snipcart HTML, which will move it above the intercom button.
  2. Change the snipcart HTML to have a BEM modifier for this specific case, and then attach a new style to move it out of the way of the intercom button (e.g. above)
  3. Move the intercom button out of the way by physically moving it via CSS, or hiding it in this particular view.

I have problems with option 3, as it goes against good UX practices to move navigation elements to different areas. I don't have a problem with option 2, except that the HTML lives in snipcart, which is hard to get access to and change. The easiest and less prone to side-effects solution is option 1, which is just adding a single style property to that button, even if it requires a level of specificity unbecoming of BEM.

jchiatt commented 5 years ago

Fixed in #7