search

DevLyon / mixter

CQRS and Event Sourcing Koans
http://devlyon.fr/mixter
MIT License
311 stars 81 forks source link

chore(maven): add mvn wrapper for Java version #32

Closed ChristopheMaldivi closed 7 years ago

ChristopheMaldivi commented 7 years ago

Hi,

It could be useful to rely on the maven wrapper since maven is not always installed. For instance on my mac I've not installed maven, but prefer to rely on the wrapper, as I am doing for gradle.

Hope this helps. Thanks for your work!

jeantil commented 7 years ago

Hello Christophe,

First of all thank you for your proposal, it is really nice to see interest in the project.

As you may have figured from the delay, we are unsure about your pull request: Having the mvn wrapper in the project will not help improve the user experience during conferences which is the main place where it is used. Conference network is spotty at best, the beginning of the workshop is not the best placet to start downloading maven binaries.

The project is setup to work with any maven verison above 3.0.0 (if you had an issue with a version in that range, please let us know) thus for now we will stay agnostic regarding the way users installs the requirements.

Thanks again for you PR, if you have any other feedback about the project please tell us !

bric3 commented 7 years ago

Hi,

My 2 cents, I'm not really against wrappers, but I don't think they add that much value. (Gradle is a different beast with an API constantly evolving, and compatibility issues).

Plus I feel uncomfortable to commit in a repo any binary like the maven-wrapper.jar. A wrapper that mimic by the tools that may be with a very high probability already present on the system.

Regarding flaky network, I'm not sure wrapper or not will make the difference, because the tool will download dependencies anyway. And in this case the speaker may have usb pen with the required binaries and the m2.

On a personal note : on mac installing maven or uninstalling it with brew can be done quite easily.

So at this moment not in favor for a maven wrapper.

jeantil commented 7 years ago

We always provide a zip file with all the necessary dependencies on a thumbdrive to avoid dependency downloads :) for the java version the zipfile contains a .m2 folder with all the required deps. You can merge that in your .m2 by hand to run the workshop so no download is required. it does assume that java users are familiar with the .m2 folder but that's usually not an issue :)