DevLyon / mixter

CQRS and Event Sourcing Koans
http://devlyon.fr/mixter
MIT License
311 stars 81 forks source link

[Scala] Test 4 Step 4 : Test is not constistent #41

Closed Xephi closed 1 year ago

Xephi commented 5 years ago

Actually, in case of a requake, the test named "notify followers when a followee requacks a message" (https://github.com/DevLyon/mixter/blob/scala/v2.1/domain/src/test/scala/mixter/domain/subscription/handlers/NotifyFollowerOfFolloweeMessageSpec.scala#L31), ask us to notify followers of the author message instead of followers of the requacker message

Potential fix (https://github.com/DevLyon/mixter/blob/scala/v2.1/domain/src/test/scala/mixter/domain/subscription/handlers/NotifyFollowerOfFolloweeMessageSpec.scala#L35) :

--- followerRepository.saveFollower(AuthorId, AFollowerId)
+++ followerRepository.saveFollower(RequackerId, AFollowerId)
fpellet commented 1 year ago

done