search

DevMoore94 / TextThem

This is an app to send text messages from the web browser
GNU General Public License v2.0
5 stars 2 forks source link

Added fork me on github ribbon #40

Closed mkowoods closed 9 years ago

mkowoods commented 9 years ago

If we end up changing the color scheme we can do it here https://github.com/blog/273-github-ribbons

DevMoore94 commented 9 years ago

That looks awesome @mkowoods! Great job! :D

DevMoore94 commented 9 years ago

Only problem I see is that when you resize the window it interferes with the responsive design of bootstrap. Is there anyway you can get it to disappear or move somewhere else when the window becomes a certain size?

syntonym commented 9 years ago

Looks great!

@DevMoore94 I don't think that's too bad. Does the "fork me" button interfere with the menu popup button for you?

DevMoore94 commented 9 years ago

No it doesn't. I suppose it's not as big of a deal as I thought. Even parts of the logo get cut off when resized. Forget I said anything haha looks great !

syntonym commented 9 years ago

Yeah the logo getting cut off realy bothers me. Maybe we could add a "small logo" (only "TT"?) and display it if the normal logo is too big? I was looking into that but had a hard time creating a good looking one. Did you create the logo yourself?

mkowoods commented 9 years ago

No just found it on the github site. Super quick drop in. We can definitely go with a smaller button or change the formatting to make more responsive. I came across this site that discusses folding with responsive(http://codepo8.github.io/css-fork-on-github-ribbon/). I was also looking for something more subtle...

We can also just do a tray of icons at the bottom.

syntonym commented 9 years ago

Sorry @mkowoods, i was talking about the "TextThem" logo that @DevMoore94 provided. I think the ribbon is fine the way it is and is subtle enough.

DevMoore94 commented 9 years ago

If you want to test that responsive mark-up on the ribbon and or logo that would be great! I love the ribbon.

mkowoods commented 9 years ago

Created issue #41 to address issues RE: Responsiveness