search

DevMoore94 / TextThem

This is an app to send text messages from the web browser
GNU General Public License v2.0
5 stars 2 forks source link

Unittest for generateRandom #51

Closed syntonym closed 9 years ago

syntonym commented 9 years ago

Adds a unittest for generateRandom and modify the generateRandom function so that it passes the test. Additionally it is cleaner and shorter now.

DevMoore94 commented 9 years ago

Merged and deployed to heroku but it is crashing the app somewhere. Did a roll back and will look into it.

DevMoore94 commented 9 years ago

I think the issue had to do with the way you change my prod switches. If you can leave those as they are for now. and send a pull request for all the other changes I will try again. :) Sorry about the confusing.

syntonym commented 9 years ago

I'll look into that. Is there some documentation of heroku so I can check against that what is needed?

DevMoore94 commented 9 years ago

Heroku has lots of documentation but crashes are usually do to a flaw in the python code. I don't think you'll find anything to useful. I think because you the code that sets up global variables to the end and changed how they were being used around.

syntonym commented 9 years ago

Yes, I thought more of "what does heroku expect?". Because it does work if executed from the command line, but I guess heroku chooses some other way (importing or whatever).

I'm currently reverting the changes back, but found or produced a bug in generateMessage(). Will request merge if I can eliminate that.

DevMoore94 commented 9 years ago

Heroku can be pretty picky. That's why when I started the project I would deploy small chunks and ensure that it was working because it's crappy trying to debug heroku apps from their logs.