search

DevOnTheRocks / RockyTweaks

A Minecraft Forge mod that adds additional functionality to other mods.
GNU General Public License v3.0
5 stars 2 forks source link

Recipe with experience cost of 0 is uncraftable #15

Closed Laike-Endaril closed 5 years ago

Laike-Endaril commented 5 years ago

I created a recipe (iron + coal = steel) and set the experience cost to 0. The recipe shows correctly in anvil and JEI but the steel ingot cannot be taken from the output slot.

Changing the experience cost to 1 allows the crafting (no other changes made).

Mohron commented 5 years ago

Not possible, unfortunately...

https://github.com/MinecraftForge/MinecraftForge/issues/1618

Laike-Endaril commented 5 years ago

@Mohron I see, thanks for looking into it.

I suppose a workaround could probably be used with a wrapper method and a special case for 0 which adds exactly 1 level to the player immediately before the successful crafting, and then passes 1 into the vanilla method, but that's a bit hacky so I won't officially request it.

Mohron commented 5 years ago

I actually thought about that as well! But for now I'll just update the scripts to error on costs less than 1

On Thu, Mar 14, 2019, 3:15 AM Laike-Endaril notifications@github.com wrote:

@Mohron https://github.com/Mohron I see, thanks for looking into it.

I suppose a workaround could probably be used with a wrapper method and a special case for 0 which adds exactly 1 level to the player immediately before the successful crafting, and then passes 1 into the vanilla method, but that's a bit hacky so I won't officially request it.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/DevOnTheRocks/RockyCore/issues/15#issuecomment-472787450, or mute the thread https://github.com/notifications/unsubscribe-auth/ADdI0rxyOW4sIKiXka9gbgOlaOcemOCkks5vWiEjgaJpZM4Y7jP1 .