search

DevOnTheRocks / RockyTweaks

A Minecraft Forge mod that adds additional functionality to other mods.
GNU General Public License v3.0
5 stars 2 forks source link

[request] JEI support for disabled "recipes" #9

Open stohun01 opened 6 years ago

stohun01 commented 6 years ago

I have a working script that disables repairing tools but still allows renaming, applying enchanted books and quark runes. However, there is no change in what is shown with JEI. Would it be possible to hide the "recipes" that contain blocked inputs and/or outputs items.

stohun01 commented 6 years ago

Would it be possible to hide the anvil tab all together. I'd rather no information than misinformation.

Mohron commented 6 years ago

That's really a question for JEI, not this mod as it will never remove the anvil all together.

stohun01 commented 6 years ago

okay, I've made a request for hiding tabs on their repo.

Skillotic0703 commented 5 years ago

So, is there any chance that this bug will get fixed? I disabled recipes and they still appear in JEI even though they don't work!

Mohron commented 5 years ago

So I think I've finally figured this one out, but with one caveat... Anvil recipes displayed as a single recipe, using the rotating items in JEI (ie. Adding an enchantment to an item, all levels are rotated through) have to be visible or hidden as a whole. So if you just want to blacklist one or more variants of that recipe, even the working ones get hidden.

So if you use this script to disable Sharpness 5 on diamonds swords

Anvil.remove([<minecraft:diamond_sword>, <minecraft:enchanted_book>.withTag({StoredEnchantments: [{lvl: 5 as short, id: 16 as short}]})]);

All Diamond Sword + Sharpness Book recipes are hidden from JEI.

Thoughts on this?

Mohron commented 5 years ago

If you would like to test this feature and provide feedback, a build is available here: https://github.com/DevOnTheRocks/RockyTweaks/releases/tag/0.6.0-PRE-RELEASE-1

ElectroBot commented 5 years ago

Not sure if I'm doing something wrong or it doesn't work:

Minecraft: 1.12.2 Forge: 14.23.5.2838 CraftTweaker: 1.12-4.1.19 JEI: 1.12.2-4.15.0.287 MTLib: 3.0.6 rockytweaks: 1.12.2-0.6.0-PRE-RELEASE-1

I am able to prevent the recipe from being craftable, but not able to remove from JEI. Tried all 4 of the items in the script (seperately and together).

script: https://paste.dimdev.org/bekubetetu.cs latest.log: https://paste.dimdev.org/eyuxiqayos.md debug.log: https://paste.dimdev.org/zeyanakeqe.md

Mohron commented 4 years ago

@ElectroBot I cannot reproduce this issue. With your scripts, pressing U over a fishing rod shows this empty anvil recipe tab:

image