search

DevOps-MBSE / AaC

Prototype Arch-as-Code
https://devops-mbse.github.io/AaC/
MIT License
27 stars 7 forks source link

CI/CD Validate Failure Argument #644

Closed lizzcondrey closed 6 months ago

lizzcondrey commented 1 year ago

As an AaC Developer, I want to add a validation failure argument, so that if warnings are present it causes a pipeline failure.

AC:

lizzcondrey commented 9 months ago

From the PR of the this work.

Pull Request https://github.com/DevOps-MBSE/AaC/pull/758 was submitted for work in the 644-cicd-validate-failure-argument branch which completes this Issue. However, another Pull Request https://github.com/DevOps-MBSE/AaC/pull/714 also contains work that implements a fail-on-warn feature. This can be observed in the following locations:

python/src/aac/plugins/check/init.py lines 21, 26 python/src/aac/plugins/check/check_impl.py lines 19, 207-208 docs/source/project_documentation/plugins/check.md lines 15, 28 python/src/aac/plugins/check/checkaac.aac line 17 For this reason, I will cancel PR https://github.com/DevOps-MBSE/AaC/pull/758, since this Issue is already addressed in PR https://github.com/DevOps-MBSE/AaC/pull/714.

lizzcondrey commented 6 months ago

This was accomplished within the #714 PR.