DevOps2018-Promotions / promotions

The promotions resource is a representation of a special promotion or sale that is running against a product or perhaps the entire store. Some examples are "buy 1 get 1 free", "20% off" etc.

MIT License

2 stars 2 forks source link

Refactored the code base and enforce persistence. #63

Closed zhangcshcn closed 6 years ago

zhangcshcn commented 6 years ago

Already deployed at nyu-promotion-service-s18.mybluemix.net

Refactored the code base for consistency with the lecture
Enforce persistence when deployed
Change the discount_ratio field to Integer (percentage) to cater to the DB
- Our DB in the cloud performs poolly when searching using Float
- Out DB is also not very capable of handling large Integer. Consider changing product_id to String. But it is find for now.
- Our DB is showing wired behavior on the primary key. Instead of growing 1 at a time, it grows 10

Glitch: The service may lose connection with the DB after a period of silence.

Zhichao-Yu commented 6 years ago

Great work!

codecov-io commented 6 years ago

Codecov Report

Merging #63 into master will decrease coverage by 1.22%. The diff coverage is 96.15%.

@@            Coverage Diff             @@
##           master      #63      +/-   ##
==========================================
- Coverage   94.81%   93.59%   -1.23%     
==========================================
  Files           2        4       +2     
  Lines         193      203      +10     
==========================================
+ Hits          183      190       +7     
- Misses         10       13       +3

Impacted Files	Coverage Δ
app/server.py	`96.93% <100%> (ø)`
app/__init__.py	`100% <100%> (ø)`
app/vcap_services.py	`62.5% <100%> (ø)`
app/models.py	`98.64% <90%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 404101b...1a0fc40. Read the comment docs.

zhangcshcn commented 6 years ago

IBM Cloud toolchain: Delivery Pipeline deployed promotions to dev, including commit 2e3fcb30a493dab2144ac3a22773fbd817f60c87

zhangcshcn commented 6 years ago

IBM Cloud toolchain: Delivery Pipeline deployed promotions to dev, including commit 2e3fcb30a493dab2144ac3a22773fbd817f60c87

zhangcshcn commented 6 years ago

IBM Cloud toolchain: Delivery Pipeline deployed promotions to prod, including commit 2e3fcb30a493dab2144ac3a22773fbd817f60c87

zhangcshcn commented 6 years ago

IBM Cloud toolchain: Delivery Pipeline deployed promotions to dev, including commit 2e3fcb30a493dab2144ac3a22773fbd817f60c87

zhangcshcn commented 6 years ago

IBM Cloud toolchain: Delivery Pipeline deployed promotions to dev, including commit 2e3fcb30a493dab2144ac3a22773fbd817f60c87

zhangcshcn commented 6 years ago

IBM Cloud toolchain: Delivery Pipeline deployed promotions to dev, including commit 2e3fcb30a493dab2144ac3a22773fbd817f60c87

zhangcshcn commented 6 years ago

IBM Cloud toolchain: Delivery Pipeline deployed promotions to dev, including commit 2e3fcb30a493dab2144ac3a22773fbd817f60c87

zhangcshcn commented 6 years ago

IBM Cloud toolchain: Delivery Pipeline deployed promotions to prod, including commit 2e3fcb30a493dab2144ac3a22773fbd817f60c87

zhangcshcn commented 6 years ago

IBM Cloud toolchain: Delivery Pipeline deployed promotions to dev, including commit 2e3fcb30a493dab2144ac3a22773fbd817f60c87

zhangcshcn commented 6 years ago

IBM Cloud toolchain: Delivery Pipeline deployed promotions to prod, including commit 2e3fcb30a493dab2144ac3a22773fbd817f60c87