DevOpsWishlist / wishlists

A collection of lists of products I wish I had
Apache License 2.0
0 stars 0 forks source link

added the Query capability to the list items/wishlist endpoints #50

Closed wyam1 closed 3 years ago

wyam1 commented 3 years ago

Added some code here without the test cases. Hoping for one of you @aklufas or @jku8 to take a look at the code and then we can start writing the test cases together.

aklufas commented 3 years ago

@jku8 can you take a look at this? the test I was trying to write doesn't work and I'm stuck

test_routes.py > lines 180ish query_wishlists_by_name

jku8 commented 3 years ago

@aklufas @wyam1 you also need to modify the routes.py file for the /wishlists and /items endpoint to handle the query logic. You can do this with an if, else.

aklufas commented 3 years ago

Updated, struggling with creating a create_items() helper function.

aklufas commented 3 years ago

@jku8 - finished the tests, this is ready for review!

ajaffery08 commented 3 years ago

LGTM