DevProgress / csv-simple-search

Generic Search and Export Tool for .csv files
Apache License 2.0
6 stars 3 forks source link

Selenium setup #57

Closed kahneraja closed 8 years ago

kahneraja commented 8 years ago

Addresses #44

kahneraja commented 8 years ago

To run these tests...

in a new console....

samuelcole commented 8 years ago

👍

alexyaseen commented 8 years ago

This wants me to install a JDK (which I don't have on this laptop) before running. However, the code looks good to me.

FYI, because we're using React, we actually don't have to use Selenium at all. Using either of these libraries would let us use a regular test framework (Mocha, Ava, etc.) to test UI:

This PR seems totally fine too, but just thought I'd let you know because the tests can run way faster and be easier to write without relying on Selenium.

kahneraja commented 8 years ago

Thanks guys.

I did take a look at enzyme with chai but im wanting to ignore a "unit test" strategy because i find it doesnt cover the orchestration of components.

Given we dont really have much complex unit logic i through getting a real dom with selenium would be more reliable

kahneraja commented 8 years ago

Ill add another few more tests, reorganise and submit

alexyaseen commented 8 years ago

Got it, makes sense