Add sorting to table columns

DevProgress / csv-simple-search

Generic Search and Export Tool for .csv files

Apache License 2.0

6 stars 3 forks source link

Add sorting to table columns #71

Open kkschick opened 8 years ago

kkschick commented 8 years ago

For #11.

TODO:

Fix jumpy column widths on sort

samuelcole commented 8 years ago

looks awesome generally! just put some comments in line, but i would also merge as is. great work.

kkschick commented 8 years ago

Thanks for the feedback, @samuelcole! The one issue I ran into with this is that the pagination makes it so that the columns jump in size when you sort (because there might be a longer column value on pg 2 that suddenly gets bumped to pg 1 on sort).

I'm not totally sure how to fix it and am not sure whether having sorting functionality outweighs the weirdness of the column jumpiness, so see what you think and let me know!