search

DevProgress / debate-bingo

Bingo game for presidential & vice presidential debates
MIT License
9 stars 7 forks source link

After bingo, free square turns into a button #7

Closed decompil3d closed 8 years ago

decompil3d commented 8 years ago

Get a bingo that includes the center free square. The free space turns into a button instead of staying a free space

kkschick commented 8 years ago

I wasn't able to reproduce this—can you take a look at my branch and verify this is working for you now?

decompil3d commented 8 years ago

Hey Katie,

I'm not at a machine that I can test your branch on right now, but I see that this repros in master (https://debate-bingo-dev.herokuapp.com) when doing a top-left to bottom-right diagonal bingo.

--Jonathan

On Fri, Sep 2, 2016 at 11:43 AM, Katie Schick notifications@github.com wrote:

I wasn't able to reproduce this—can you take a look at my branch and verify this is working for you now?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/DevProgress/debate-bingo/issues/7#issuecomment-244456548, or mute the thread https://github.com/notifications/unsubscribe-auth/AUCcj7dpFHD_JH88kLLh4cY3Gc040yQGks5qmG48gaJpZM4Jx8v0 .

kkschick commented 8 years ago

Ah, I see. Yep, this should be fixed now on my branch.

decompil3d commented 8 years ago

Still repros after commit 23f440f (your last pr). Can you take another look?