fix for issues 14 and 22: footer now sticks to bottom of content

DevProgress / devprogress.github.io

GitHub Organizational Page

MIT License

9 stars 4 forks source link

fix for issues 14 and 22: footer now sticks to bottom of content #23

Open richardharrington opened 7 years ago

decause commented 7 years ago

@mattrothenberg @kahneraja

Wanna give this a look? +1 from me so long as it works as expected :)

mattrothenberg commented 7 years ago

@decause @kahneraja I don't think @richardharrington's change will fix this issue. Instead of making the footer absolute, we should add more padding to the bottom of the containing element that the footer is fixed in. I'm actually unable to reproduce the issue on Mac Firefox myself.

richardharrington commented 7 years ago

@mattrothenberg That's what I would have thought if I had only seen #22 , but #14 seems to be saying we should get rid of the fixed nature of the footer entirely. Should we go with #14 , or should we ignore it and close it?

By the way, I can reproduce #22 on my Mac Firefox. It is pretty bad. #14 I also agree with, but it is a judgment call unlike #22.