fix modal scrolling on iOS Safari

DevProgress / maps-showcase

Mobile friendly website with video landing page, slideshows, slideshow selector in the form of a map of the US.

GNU Affero General Public License v3.0

5 stars 7 forks source link

fix modal scrolling on iOS Safari #112

Closed kielni closed 8 years ago

kielni commented 8 years ago

Fix for https://github.com/DevProgress/maps-showcase/issues/92

There's a bug in Safari; super long discussion and fix from https://github.com/twbs/bootstrap/issues/14839

I can reproduce the bug and fix with the Xcode simulator, but haven't (yet) tried it on a real iPhone.

jtbandes commented 8 years ago

Hi @kielni, I believe this should be fixed by #110. @bscofield and I worked on this and found that overflow-y: auto was not sufficient to fix the problem; it can still be triggered when the images are loaded in after a delay. My PR includes some code to toggle overflow-y:hidden on the container to force Safari to recalculate the modal's height.

decause commented 8 years ago

:+1:

decause commented 8 years ago

:ship: :ship: :ship:

jtbandes commented 8 years ago

Closing in favor of #110 which I just merged.