search

DevSolar / pdclib

The Public Domain C Library
https://pdclib.rootdirectory.de
Creative Commons Zero v1.0 Universal
224 stars 41 forks source link

Fix strto{u,}{l,ll}("0"). #1

Closed giomasce closed 5 years ago

giomasce commented 5 years ago

Calling strto{u,}{l,ll}("0") sets endptr incorrectly. See the tests and the fix in the suggested commit.

Thanks for PDClib, it's a great project.

DevSolar commented 5 years ago

Thank you for your contribution! It's bugs like this that bother me the most -- I can live with PDCLib being incomplete, but the parts that are implemented should be bug-free so that people can use them with confidence.

I will address this issue ASAP, which might however take a couple of days more. I just wanted to give you the heads-up that your contribution has been kindly received.

giomasce commented 5 years ago

Yeah, this kind of corner case can be really tough, unfortunately. Happy to have helped, and all the best!

DevSolar commented 5 years ago

That was a beauty to merge. Thank you again for your help with this.