DevSolar
commented
5 years ago Hello Lucas,
that's what you get for following the standard to the letter even in the naming of parameters. :-D You are absolutely right, of course. I will fix this right away.
Regards, Martin
Am 05.04.2019 18:30, schrieb Lucas:
During compilation of a C++ project I noticed that the keyword new was used in a few places throughout PDClib. This resulted in various errors which could easily be avoided.
I read Notes.txt and understand that this change might be non-conventional but I figure that the goal justifies the means.
YOU CAN VIEW, COMMENT ON, OR MERGE THIS PULL REQUEST ONLINE AT:
https://github.com/DevSolar/pdclib/pull/2 [1]
COMMIT SUMMARY
- Avoid C++ keywords
FILE CHANGES
- M functions/stdio/rename.c [2] (6)
- M include/stdio.h [3] (2)
- M platform/example/functions/_PDCLIB/_PDCLIB_rename.c [4] (8)
PATCH LINKS:
- https://github.com/DevSolar/pdclib/pull/2.patch [5]
- https://github.com/DevSolar/pdclib/pull/2.diff [6]
-- You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub [7], or mute the thread [8].
Links:
[1] https://github.com/DevSolar/pdclib/pull/2 [2] https://github.com/DevSolar/pdclib/pull/2/files#diff-0 [3] https://github.com/DevSolar/pdclib/pull/2/files#diff-1 [4] https://github.com/DevSolar/pdclib/pull/2/files#diff-2 [5] https://github.com/DevSolar/pdclib/pull/2.patch [6] https://github.com/DevSolar/pdclib/pull/2.diff [7] https://github.com/DevSolar/pdclib/pull/2 [8]
-- Martin Baute solar@rootdirectory.de
During compilation of a C++ project I noticed that the keyword
newwas used in a few places throughout PDClib. This resulted in various errors which could easily be avoided.I read Notes.txt and understand that this change might be non-conventional but I figure that the goal justifies the means.