DevSrSouza / compose-icons

Popular Open Source icon packs for Compose Multiplatform
MIT License
551 stars 25 forks source link

More Icons , Compose & Kotlin Updates , Search Icons in Demo App #24

Closed wakaztahir closed 1 year ago

wakaztahir commented 1 year ago

You must update the version and then publish it , It will require a lot of time to build , since MaterialDesignIcons has more than 7000 icons

I have merged Jetbrains and Jetpack Compose Releases , Now common libraries are under "jetbrains" group name , upgraded gradle & project configuration and the signing/publishing configuration is same , A Web target has been added. I added a demo app as well

wakaztahir commented 1 year ago

I have made these changes to my fork

I won't be making another pull request , Please merge this pull request and reply here so I can make another pull request and merge that one as well. I have changed a little publishing information which is causing me a little headache but I'll fix it.

DevSrSouza commented 1 year ago

Hi! Thanks for the contribution, I Will take a look at the PR soon

DevSrSouza commented 1 year ago

Can you also comment images and gifs of the app?

wakaztahir commented 1 year ago

The app works , I've tested it , in the debug version

compose-icons

capture-2

wakaztahir commented 1 year ago

seems like this pull request does contain new commits , its a little unfinished. can you please publish the new release (I need those icons)

The release MSI gives this error due to proguard , I have installed the debug msi to search icons , its around 150mbs https://github.com/JetBrains/compose-jb/issues/2650 I have reported it , Its caused by some icon files made by fluentui-system-icons or jetpack compose or proguard bug

Things to do before release

Side note 5e9f314

I did't go through with this commit , I had to revert creating a map inside .kts files , because I realised ImageVector has a name property , so most of the files are unchanged

DevSrSouza commented 1 year ago

Can you create small Pull Request? For each change. For example, Multiple PRs for each new icon pack, update gradle configuration and all dependencies versions, uniting jetbrains and android targets, creating the sample/converter application (demo app).

I willing to get all this contribution of yours and open small pull request and increment things I want for the project as well.

DevSrSouza commented 1 year ago

Also I pretend to replace the way I publish/generate icons by having the generated source at build folder and having binary-compatibility-validator commited

DevSrSouza commented 1 year ago

The source code of the project it huge, the PR got huge because of the new icons and this make impossible to review.