search

DevTips / Parallax-on-the-Web-DevTips-

The code that accompanies the video series on YouTube called "Parallax on the Web" — https://www.youtube.com/playlist?list=PLqGj3iMvMa4IyCbhul-PdeiDqmh4ooJzk
345 stars 242 forks source link

Little image adjustments #2

Open ghost opened 9 years ago

ghost commented 9 years ago

Hi, I just wanto to propose a couple of changes to the images. First, the background of the header: it is repeated, so I simply cut 20px from the left side. In this way the repetition is quite more discreet. Second, I reflected the bird, so during the scroll the title is more legible. I would also have decreased the left margin of the .fore-bird to -445px, giving a bit of space to the title*.

I created another branch, in which I have experienced a lot. If you have some time to waste, please, give a look (https://github.com/LoogleeTk/Parallax-on-the-Web-DevTips-/tree/personal) and let me know what you think.

* I have done it in the other branch.

ajspeller commented 9 years ago

I especially like the reflection of the bird.

travisneilson commented 9 years ago

Hey @LoogleeTk Thanks so much for taking this on and making it your own. I love that. I love that github really puts this code in your hands and enables you to do things like this.

I don't think I'm going to pull this in though. I accepted pull requests on another video series I made and it mostly confused people. I have about 4 more videos completed on this series. Pulling this in would kind of disrupt the flow of that.

I really think it's great that you did this though. It's wonderful.

ghost commented 9 years ago

Yeah, I understand. I'll keep on hacking on both.

systimotic commented 9 years ago

Idea: when you think you're done with the series, you can do a little "fixing up" episode, where you go through and fix, clean up and make things better.

travisneilson commented 9 years ago

Great idea @TimohStudios , thank you so much! I'm going to make a video where I explain these pull requests (giving credit to you guys, of course) and pull them in.

If you can resolve this Merge Conflict before next Tuesday (26th) I'll be sure to get this on the video so everyone can see the awesome work you did!

ghost commented 9 years ago

Sorry @travisneilson, even though I tried a lot, I couldn't solve the merge conflicts. If you wanna see my work, I have uploaded it on my domain, but if you want to have a look to the code, you need to download the .zip from GitHub.

travisneilson commented 9 years ago

Oh cool, Your version looks cool!

Tell you what. I'll point out your work and scroll through your version (as it's such a big departure, maybe it's best not to pull it in.)

If you did want to submit something else, maybe a small fix or optimization. Maybe that cool Preloader :) —I'd be able to pull in an isolated thing like that...

Thanks for your work!!