DevToys-app / DevToys

A Swiss Army knife for developers.
https://devtoys.app/
MIT License
26.94k stars 1.45k forks source link

PNG / JPEG Compressor: Save all button doesn't work #322

Closed ZalaPanda closed 2 years ago

ZalaPanda commented 2 years ago

Description

Nothing happens if I press the Save all button.

NOTE: The Save as button works as expected.

Steps To Reproduce

  1. Go to PNG/JPEG Compressor
  2. Add image
  3. Press the Save all button

Expected behavior

The original image files should be overwritten with the reduced version.

DevToys Version

1.0.1.0

Relevant Assets/Logs

Nothing relevant in the logs.txt.
BTW I can see the reduced version of the image in the %localappdata%\...\LocalCache folder.

youkai95 commented 2 years ago

I am experiencing this issue in Windows 10. It seems related to a folder picker that should open to select where to save the pictures.

In my case that picker never opens and just steps out of the property setter.

rlm96 commented 2 years ago

Could you give us information about your Windows version?

veler commented 2 years ago

Hello,

Thanks for sharing this. We believe we fixed the issue a few days ago.

https://github.com/veler/DevToys/issues/151

If you can, would you please be able to checkout the latest commit and try the app on your machine to see if it works?

We will release an update asap. 😊

Thanks!

youkai95 commented 2 years ago

Could you give us information about your Windows version?

Windows 10 v2004, Build 1904

If you can, would you please be able to checkout the latest commit and try the app on your machine to see if it works?

I had not tried it in a recent code version and I did it now and it works correctly, I consider this issue is solved in main branch.

veler commented 2 years ago

Awesome! Thank you for checking :) I will close the issue.

ZalaPanda commented 2 years ago

Thank you very much! You guys are awesome! 😄