search

DevYukine / red_oxide

A CLI helping with uploading to Redacted, inspired by REDBetter
MIT License
114 stars 21 forks source link

invalid_track_number_vinyl - Why Disable Automatic Upload? #18

Open SellingEngland opened 10 months ago

SellingEngland commented 10 months ago

When a vinyl with invalid track numbers is detected, why do you then set cmd.automatic_upload to false?

Looking at your main.rs, it will always run the prompt to fix the tags if invalid_track_number_vinyl is true, and the uploading portion of the code is below that.

Therefore, the user will get the prompt to fix the tags, and can answer either yes or no that the tags are fixed. If they answer yes, then I think automatic upload should proceed as normal. Unless I'm missing something.

DevYukine commented 9 months ago

This was done to ensure the user takes care of this issue themself as thats not something you can easily automate.

It actually doesn't asks the user to "fix the tags" but instead just goes to hash validation for torrents and then to spectogram analysis, this is why i originally disabled auto upload forcefully.