`Flac` transcode target is ignored when `skip_existing_formats_check` is `true` and source is `Flac24` - Githubissues

DevYukine / red_oxide

A CLI helping with uploading to Redacted, inspired by REDBetter

MIT License

116 stars 22 forks source link

`Flac` transcode target is ignored when `skip_existing_formats_check` is `true` and source is `Flac24` #25

Open RogueOneEcho opened 6 months ago

RogueOneEcho commented 6 months ago

I'm working my way through the source and was curious if this behaviour is intentional or not?

If you are attempting to:

transcode from Flac24
allowed_transcode_formats contains Flac
skip_existing_formats_check is false

then I would have expected that Flac would be included in transcode_formats but this is explicitly ignored:

https://github.com/DevYukine/red_oxide/blob/3d20de10dad10894b0d535af06acb5e2ccb0ecd3/src/command/transcode.rs#L198

Is this the expected behaviour?