search

Devamani11D / salt-app-kickstart

A CLI tool that can be installed as an npm package, featuring pre-installed Salt dependencies and templates such as AGGrid, Dashboard etc. Simplifies project setup by automatically launching on localhost.
MIT License
8 stars 10 forks source link

terminate the process on CTRL-C or CTRL-D #11

Closed nikhilkalburgi closed 2 days ago

nikhilkalburgi commented 4 days ago

Current behavior:

The process continues to execute after it is terminated: image

Expected behavior:

It should terminate with a message printed like:

// Inside catch
console.log(chalk.red(`Process has been terminated. ${error.message}`));
adityakalburgi commented 4 days ago

@nikhilkalburgi i will do this

Devamani11D commented 4 days ago

@adityakalburgi , Please go ahead with the work!!Assigning it to you!

Devamani11D commented 4 days ago

@nikhilkalburgi , I dont know whether it can be assigned level3, Can you please look into it once!

nikhilkalburgi commented 4 days ago

Hi @Devamani11D, I added this considering the work that is required to analyse the code and do the change. But, if you think the level should be less then feel free to change it.

By the way, I have updated the levels name to what GSSoC wants us to have. Have a look at it as well. See if any other thing is pending.

Devamani11D commented 4 days ago

Yes @nikhilkalburgi !! I have checked it now. The names are as per their guidelines. Thank you for doing that. And yeah , Regarding level for this issue , I feel level2 is fine. Changing it now!

Devamani11D commented 3 days ago

Hey @nikhilkalburgi , Can i please know how to correct or add the labels to any project in which i am a collaborator in that project but i cannot see that settings icon to add topics to the project.

nikhilkalburgi commented 3 days ago

Hi @Devamani11D , I changed it in the labels section that comes beside any issue page. Click on the settings icon on the labels section. Then you will get options to add new labels + one last option to edit or create new labels.