search

Devan-Kerman / ARRP

A fabric api for creating resources and assets at runtime
Mozilla Public License 2.0
101 stars 25 forks source link

Loot table conditions is created as condition #20

Closed OroArmor closed 3 years ago

OroArmor commented 3 years ago

https://github.com/Devan-Kerman/ARRP/blob/2c30a225e0316295c03a1e29392012ebd34256ad/src/main/java/net/devtech/arrp/json/loot/JCondition.java#L20-L24

image

Devan-Kerman commented 3 years ago

isn't that WAI tho

OroArmor commented 3 years ago

WAI?

Devan-Kerman commented 3 years ago

working as intended

Devan-Kerman commented 3 years ago

what's the bug here, aren't conditions supposed to look like that

OroArmor commented 3 years ago

no, the normal loottable is image (yes its for wheat, but the other image is for a similar crop)

OroArmor commented 3 years ago

wait i just looked at the code, and this should be working. but i don't know why its different...

Devan-Kerman commented 3 years ago

you made 2 seperate entries objects

Fusion-Flux commented 3 years ago

removing an entry doesnt fix anything

Fusion-Flux commented 3 years ago

image

Devan-Kerman commented 3 years ago

wait that's correct right? im so confused, can u send me a diff of what you're expecting vs what the output is, and ur code

Fusion-Flux commented 3 years ago

well it should end up lookin like this image

Devan-Kerman commented 3 years ago

the only difference is condition vs conditions ohhhhhhhhhhhhhhhhh smh u guys are bad at explaining bugs

Devan-Kerman commented 3 years ago

will fix

Devan-Kerman commented 3 years ago

should be fixed in release 0.3.5