search

Devan-Kerman / ARRP

A fabric api for creating resources and assets at runtime
Mozilla Public License 2.0
101 stars 25 forks source link

Use own logger in mixin instead of shadowing, fixing 22w03a #53

Closed triphora closed 2 years ago

triphora commented 2 years ago

With 22w03a's switch to slf4j, the shadowed field with that signature no longer exists. This means that ARRP crashes with mixin failures on 22w03a. This changes the mixin to use its own logger instead of relying on the shadowed one, so that old compat can be kept whilst fixing 22w03a.

Only tested against 22w03a, no reason this won't work on older versions.

triphora commented 2 years ago

looks like this is broken again on 22w06a -- will investigate in a bit

triphora commented 2 years ago

Honestly not sure how to do this, so I'm going to close this. Support for 1.18.1 and below is pretty much thrown out the window. I recommend looking into Fabric API's ResourceManagerHelper#registerBuiltinResourcePack, but it's not up to me whether you want to depend upon Fabric API or not.