search

Devan-Kerman / ARRP

A fabric api for creating resources and assets at runtime
Mozilla Public License 2.0
104 stars 27 forks source link

JLang.entity() uses wrong translation key type #68

Closed Fourmisain closed 2 years ago

Fourmisain commented 2 years ago

ARRP's JLang.entity() produces translation keys of the form "entity_type.<namespace>.<path>" when it should be "entity.<namespace>.<path>".

The latter can be seen in the Minecraft en_us.json file, e.g. "entity.minecraft.polar_bear": "Polar Bear" and EntityType.getTranslationKey() also uses "entity".

Not a big deal when there's JLang.entityRespect(), just letting you know. Should be easily fixed by changing these 2 strings here: https://github.com/Devan-Kerman/ARRP/blob/42ff4d62f83dd82d290cbd13724b589d7dc5b7a2/src/main/java/net/devtech/arrp/json/lang/JLang.java#L114-L115 https://github.com/Devan-Kerman/ARRP/blob/42ff4d62f83dd82d290cbd13724b589d7dc5b7a2/src/main/java/net/devtech/arrp/json/lang/JLang.java#L146-L147

Devan-Kerman commented 2 years ago

This was done to avoid breaking backwards compatibility if I remember correctly