DevanB / wtgs

Where to Go Scouting is a geolocation app built with Meteor to show locations where Scouts can go!
http://www.wheretogoscouting.org
0 stars 0 forks source link

Allow user to dismiss modal box. #21

Closed dimwell closed 9 years ago

dimwell commented 9 years ago

Two options:

  1. Give us an email.
  2. Click an "X" in the corner somewhere.

Both should dismiss the modal box.

DevanB commented 9 years ago

Begin able to close the modal adds what advantage? (just playing devil’s advocate)

Also, if user closes modal and later wants to give email, they have to refresh page. You okay with this?

On Jul 27, 2015, at 12:37 PM, Chris Brightwell notifications@github.com wrote:

Two options:

Give us an email.

Click an "X" in the corner somewhere.

Both should dismiss the modal box.

— Reply to this email directly or view it on GitHub https://github.com/DevanB/wtgs/issues/21.

dimwell commented 9 years ago

Begin able to close the modal adds what advantage? (just playing devil’s advocate)

It lets them poke around the data and view the current prototype.

Also, if user closes modal and later wants to give email, they have to refresh page. You okay with this?

Yes. I figure that the "X" and the email submit are intentional enough to be okay. If they can dismiss via accidental click on the background, that might be an issue.

DevanB commented 9 years ago

Cool. Just throwing some questions out there.

On Jul 27, 2015, at 2:13 PM, Chris Brightwell notifications@github.com wrote:

Begin able to close the modal adds what advantage? (just playing devil’s advocate)

It lets them poke around the data and view the current prototype.

Also, if user closes modal and later wants to give email, they have to refresh page. You okay with this?

Yes. I figure that the "X" and the email submit are intentional enough to be okay. If they can dismiss via accidental click on the background, that might be an issue. — Reply to this email directly or view it on GitHub https://github.com/DevanB/wtgs/issues/21#issuecomment-125310860.

DevanB commented 9 years ago

I think closing modal on email subscribe isn't such a great UX. User needs to see if the email succeeded because it tells them to check their email.

Yes, I just checked on wheretogoscouting.org and it is giving feedback after subscription. Not sure why you aren't seeing it.

dimwell commented 9 years ago

Leaving it open after email confirmation is fine.

DevanB commented 9 years ago

Yeah, I think this is the best UX.

This has been deployed.