Devanshshah1309 / pe

0 stars 0 forks source link

Inconsistent Error Messages for `task delete` #4

Open Devanshshah1309 opened 2 years ago

Devanshshah1309 commented 2 years ago

Steps to Reproduce

Assuming you only have 5 tasks in your application, run:

  1. delete task 0
  2. delete task 10

Expected

Both commands are invalid in the exact same way - since the task index is invalid in both cases - and so we expect both commands to show the exact same error message. However, the error message for both are different, which might confuse users as to why the 2 numbers are being treated differently even though they're both invalid. Low priority since it does not hinder the usage.

Actual

Screenshot 2022-11-11 at 4.30.47 PM.png

Screenshot 2022-11-11 at 4.33.22 PM.png

soc-se-bot commented 2 years ago

Team's Response

It's clear in the user guide that the command expects a positive integer, and hence the error is shown asking you to input a positive integer before checking for valid index

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]