Devasy23 / FaceRec

An advanced facial recognition system designed for real-time identification using deep learning models and optimized vector search. Features include face detection, embedding generation, and scalable deployment options.
Apache License 2.0
31 stars 30 forks source link

Merge code mark 1 #3

Closed Devasy23 closed 8 months ago

Devasy23 commented 8 months ago

Description

This pull request introduces the ability to handle multiple images for each employee in our face recognition system. This includes changes to the create_new_faceEntry function to process multiple images, as well as updates to our test suite to cover these new functionalities.

Changes

Fixes

Testing

All tests pass with the new changes. Test coverage remains at 100%.

Please review and let me know if you have any questions or feedback.

codecov-commenter commented 8 months ago

Codecov Report

Attention: Patch coverage is 98.03922% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 70.40%. Comparing base (47cc66b) to head (be9f403). Report is 2 commits behind head on main.

Files Patch % Lines
API/route.py 95.65% 1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3 +/- ## ========================================== + Coverage 66.66% 70.40% +3.73% ========================================== Files 6 7 +1 Lines 216 250 +34 ========================================== + Hits 144 176 +32 - Misses 72 74 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

devansh-shah-11 commented 8 months ago

Hey @Devasy23 ,

The code is functioning pretty well.

1) However, the update function needs to have the embeddings stored. 2) Also, it would be great if logging statements are written in the API endpoints to ensure easy debugging