Closed Devasy23 closed 8 months ago
Attention: Patch coverage is 98.03922%
with 1 lines
in your changes are missing coverage. Please review.
Project coverage is 70.40%. Comparing base (
47cc66b
) to head (be9f403
). Report is 2 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
API/route.py | 95.65% | 1 Missing :warning: |
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Hey @Devasy23 ,
The code is functioning pretty well.
1) However, the update function needs to have the embeddings stored. 2) Also, it would be great if logging statements are written in the API endpoints to ensure easy debugging
Description
This pull request introduces the ability to handle multiple images for each employee in our face recognition system. This includes changes to the
create_new_faceEntry
function to process multiple images, as well as updates to our test suite to cover these new functionalities.Changes
create_new_faceEntry
function to handle multiple images for each employee.Employee
andUpdateEmployee
models to include a list of images instead of a single image.test_face_lifecycle
function to handle multiple images for each employee in the test data.test_face_cycle.py
to handle multiple images for each employee.Fixes
create_new_faceEntry
function was not correctly processing multiple images for each employee.Testing
All tests pass with the new changes. Test coverage remains at 100%.
Please review and let me know if you have any questions or feedback.